linux-kernel - Re: [Pv-drivers] [PATCH 0/1] VM Sockets for Linux upstreaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1231523602.1815949.1360197150398.JavaMail.root@vmware.com>
Date:	Wed, 6 Feb 2013 16:32:30 -0800 (PST)
From:	Andy King <acking@...are.com>
To:	Gerd Hoffmann <kraxel@...hat.com>
Cc:	pv-drivers@...are.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	gregkh@...uxfoundation.org, davem@...emloft.net
Subject: Re: [Pv-drivers] [PATCH 0/1] VM Sockets for Linux upstreaming

Hi Gerd,

> > linux/vmw_vmci_defs.h: No such file or directory
> > compilation terminated.
> > make[4]: *** [net/vmw_vsock/af_vsock.o] Error 1
> 
> Oops, you're right, it really shouldn't need that header.  Sorry
> about that, let me rip that out.

Fixed.  The VMCI headers are now gone from the core in af_vsock.*
and vsock_addr.*

> > Only vmw_vsock_vmci_transport should have a vmw_vmci dependency,
> > not vsock ...
> 
> Agreed, that's not right, I'll fix that too.

Fixed, lsmod now shows that only the transport has a dependency.

Also, it turns out that we do need a dgram_recv(), since our
transport currently enqueues skbs with VMCI DGRAMs in them, which
need to be converted before copying into the user's buffer.  I've
added that too.

Please see latest patchset (sent a few minutes ago), hope it works
for you this time.

Thanks!
- Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/