linux-kernel - Re: [PATCH 3/5] r8169: Modify the method for setting firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130207000252.GB2784@electric-eye.fr.zoreil.com>
Date:	Thu, 7 Feb 2013 01:02:52 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Hayes Wang <hayeswang@...ltek.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] r8169: Modify the method for setting firmware

Hayes Wang <hayeswang@...ltek.com> :
> Remove useless action PHY_READ_EFUSE, and define the new action
> PHY_MDIO_CHG.
> 
> PHY_MDIO_CHG is used to modify the mdio operation. By the way, the
> firmware could support setting mac ocp.
> 
[...]
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index d1bee4c..55a7fb5 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
[...]
> @@ -2321,8 +2339,15 @@ static void rtl_phy_write_fw(struct rtl8169_private *tp, struct rtl_fw *rtl_fw)
>  		case PHY_BJMPN:
>  			index -= regno;
>  			break;
> -		case PHY_READ_EFUSE:
> -			predata = rtl8168d_efuse_read(tp, regno);
> +		case PHY_MDIO_CHG:
> +			if (data == 0) {
> +				ops->write = org.write;
> +				ops->read = org.read;
> +			} else if (data == 1) {
> +				ops->write = mac_mcu_write;
> +				ops->read = mac_mcu_read;
> +			}

Did you check that none of rtl_nic/rtl8168d-{1, 2}.fw uses PHY_READ_EFUSE ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/