[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5hhalo75ck.wl%tiwai@suse.de>
Date: Thu, 07 Feb 2013 12:04:11 +0100
From: Takashi Iwai <tiwai@...e.de>
To: H Hartley Sweeten <hsweeten@...ionengravers.com>
Cc: <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 11/11] sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers
At Wed, 6 Feb 2013 15:32:50 -0700,
H Hartley Sweeten wrote:
>
> Use the new module_pcmcia_driver() macro to remove the boilerplate
> module init/exit code in the pcmcia drivers.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
Acked-by: Takashi Iwai <tiwai@...e.de>
(But please add subsystem maintainers to Cc at the next time...)
Takashi
> ---
> sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +--------------
> sound/pcmcia/vx/vxpocket.c | 14 +-------------
> 2 files changed, 2 insertions(+), 27 deletions(-)
>
> diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c
> index f9b5229..8f489de 100644
> --- a/sound/pcmcia/pdaudiocf/pdaudiocf.c
> +++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c
> @@ -295,18 +295,5 @@ static struct pcmcia_driver pdacf_cs_driver = {
> .suspend = pdacf_suspend,
> .resume = pdacf_resume,
> #endif
> -
> };
> -
> -static int __init init_pdacf(void)
> -{
> - return pcmcia_register_driver(&pdacf_cs_driver);
> -}
> -
> -static void __exit exit_pdacf(void)
> -{
> - pcmcia_unregister_driver(&pdacf_cs_driver);
> -}
> -
> -module_init(init_pdacf);
> -module_exit(exit_pdacf);
> +module_pcmcia_driver(pdacf_cs_driver);
> diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c
> index 8f93504..d4db7ec 100644
> --- a/sound/pcmcia/vx/vxpocket.c
> +++ b/sound/pcmcia/vx/vxpocket.c
> @@ -367,16 +367,4 @@ static struct pcmcia_driver vxp_cs_driver = {
> .resume = vxp_resume,
> #endif
> };
> -
> -static int __init init_vxpocket(void)
> -{
> - return pcmcia_register_driver(&vxp_cs_driver);
> -}
> -
> -static void __exit exit_vxpocket(void)
> -{
> - pcmcia_unregister_driver(&vxp_cs_driver);
> -}
> -
> -module_init(init_vxpocket);
> -module_exit(exit_vxpocket);
> +module_pcmcia_driver(vxp_cs_driver);
> --
> 1.8.1.1.293.gfe73786
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists