linux-kernel - Re: [PATCH 1/5] cpufreq: Retrieve current frequency from scaling drivers with internal governors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Feb 2013 19:16:20 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	dirk.brandewie@...il.com
Cc:	linux-kernel@...r.kernel.org, cpufreq@...r.kernel.org
Subject: Re: [PATCH 1/5] cpufreq: Retrieve current frequency from scaling
 drivers with internal governors

On Wed, Feb 6, 2013 at 10:32 PM,  <dirk.brandewie@...il.com> wrote:
> From: Dirk Brandewie <dirk.brandewie@...il.com>
>
> Scaling drivers that implement the cpufreq_driver.setpolicy() versus
> the cpufreq_driver.target() interface do not set policy->cur.
>
> Normally policy->cur is set during the call to cpufreq_driver.target()
> when the frequnecy request is made by the governor.
>
> If the scaling driver implements cpufreq_driver.setpolicy() and
> cpufreq_driver.get() interfaces use cpufreq_driver.get() to retrieve
> the current frequency.
>
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@...el.com>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

To fix sparse warning updated this patch as:

commit f6060fa13ace2da4e691233706a788f91ad453da
Author: Viresh Kumar <viresh.kumar@...aro.org>
Date:   Thu Feb 7 19:12:16 2013 +0530

    fixup! cpufreq: Retrieve current frequency from scaling drivers
with internal governors
---
 drivers/cpufreq/cpufreq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 447b313..e140b81 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1173,12 +1173,12 @@ static void cpufreq_out_of_sync(unsigned int
cpu, unsigned int old_freq,
  */
 unsigned int cpufreq_quick_get(unsigned int cpu)
 {
+       struct cpufreq_driver *driver = rcu_dereference(cpufreq_driver);
        struct cpufreq_policy *policy;
        unsigned int ret_freq = 0;

-       if (cpufreq_driver && cpufreq_driver->setpolicy &&
-                       cpufreq_driver->get)
-                       return cpufreq_driver->get(cpu);
+       if (driver && driver->setpolicy && driver->get)
+                       return driver->get(cpu);

        policy = cpufreq_cpu_get(cpu);
        if (policy) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/