linux-kernel - Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130207010914.GA9070@verge.net.au>
Date:	Thu, 7 Feb 2013 10:09:14 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Zhang Yanfei <zhangyanfei@...fujitsu.com>
Cc:	Julian Anastasov <ja@....bg>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux MM <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kamezawa.hiroyu@...fujitsu.com, minchan@...nel.org, mgorman@...e.de
Subject: Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max

On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
> 于 2013年02月06日 17:29, Julian Anastasov 写道:
> > 
> > 	Hello,
> > 
> > 	Sorry that I'm writing a private email but I
> > deleted your original message by mistake. Your change
> > of the sysctl_sync_qlen_max from int to long is may be
> > not enough.
> > 
> > 	net/netfilter/ipvs/ip_vs_ctl.c contains
> > proc var "sync_qlen_max" that should be changed to
> > sizeof(unsigned long) and updated with proc_doulongvec_minmax.
> > 
> 
> Thanks for pointing this. I will update this in patch v2.

Hi Zhang,

Thanks for helping to keep IPVS up to date.

It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
may also need to be updated.

Could you look at including that in v2 too?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/