linux-kernel - Re: [PATCH 37/77] i2c: convert to idr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130207163247.GL2875@htj.dyndns.org>
Date:	Thu, 7 Feb 2013 08:32:47 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Jean Delvare <khali@...ux-fr.org>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 37/77] i2c: convert to idr_alloc()

Hello,

On Thu, Feb 07, 2013 at 03:28:31PM +0000, Mark Brown wrote:
> On Wed, Feb 06, 2013 at 11:40:09AM -0800, Tejun Heo wrote:
> > Convert to the much saner new idr interface.
> > 
> > Only compile tested.
> 
> This broke I2C for me in -next today, I saw a spinlock bad magic error
> calling pm_runtime_enable().  

Hmmm... weird, can't see where the difference in behavior would come
from.  The only material difference would be if id < 0 && id != -1 in
i2c_add_numbered_adapter(), which now would trigger WARN_ON_ONCE()
inside idr_alloc() instead of silently returning -EINVAL.

Can you please elaborate the failure?  I can't see how the idr
conversion would lead to spinlock bad magic error.  Does reverting
this patch make the problem go away?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/