linux-kernel - Re: [PATCH] ARM: dts: add minimal DT support for DevKit8000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130207173949.GA21723@e106331-lin.cambridge.arm.com>
Date:	Thu, 7 Feb 2013 17:39:49 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Anil Kumar <anilk4.v@...il.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"b-cousson@...com" <b-cousson@...com>,
	"tony@...mide.com" <tony@...mide.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"thomas@...weber.eu" <thomas@...weber.eu>
Subject: Re: [PATCH] ARM: dts: add minimal DT support for DevKit8000

Hello,

I have a couple of minor comments.

On Thu, Feb 07, 2013 at 02:11:37PM +0000, Anil Kumar wrote:
> DevKit8000 is a beagle board clone from Timll, sold by
> armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
> S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
> JTAG interface.
> 
> This patch adds the basic DT support for devkit8000. At this time, Information
> of twl4030, MMC1, I2C1, leds and there pim mux information are added.
> 
> Signed-off-by: Anil Kumar <anilk4.v@...il.com>
> Tested-by: Thomas Weber <thomas@...weber.eu>
> ---
> 
>  -This patch is based on top of kernel 3.8-rc5.
> 
>  -Tested on Devkit8000.
> 

[...]

> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
> new file mode 100644
> index 0000000..9864fd7
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> @@ -0,0 +1,125 @@
> +/*
> + * Anil Kumar <anilk4.v@...il.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +/dts-v1/;
> +
> +/include/ "omap3.dtsi"
> +/ {
> +	model = "TI OMAP3 Devkit8000";

Should this not be "TimLL Devkit8000" ?

> +	compatible = "ti,omap3-devkit8000", "ti,omap3";

"timll,devkit8000" ?

[...]

Thanks,
Mark.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/