linux-kernel - Re: [char-misc-next 05/11] mei: bus: Call bus routines from the core code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201302072237.31048.arnd@arndb.de>
Date:	Thu, 7 Feb 2013 22:37:30 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	gregkh@...uxfoundation.org, sameo@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [char-misc-next 05/11] mei: bus: Call bus routines from the core code

On Thursday 07 February 2013, Tomas Winkler wrote:
> @@ -197,6 +197,9 @@ static int mei_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>         mei_pdev = pdev;
>         pci_set_drvdata(pdev, dev);
>  
> +       err = mei_bus_init(mei_pdev);
> +       if (err)
> +               goto deregister_mei;
>  
>         schedule_delayed_work(&dev->timer_work, HZ);
>  

This is fairly unusual, and will break if you ever have multiple mei devices
in one system, because you end up registering the bus type for each
device. I think it would be more logical to register/unregister
the bus_type from the module_init/exit functions of the module
that contains the bus_type object.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/