linux-kernel - Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201302072241.07171.arnd@arndb.de>
Date:	Thu, 7 Feb 2013 22:41:06 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	gregkh@...uxfoundation.org, sameo@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation

On Thursday 07 February 2013, Tomas Winkler wrote:
> +}
> +EXPORT_SYMBOL(mei_add_device);
> +
> +void mei_remove_device(struct mei_bus_client *client)
> +{
> +       device_unregister(&client->dev);
> +}
> +EXPORT_SYMBOL(mei_remove_device);

One more point: did you intentionally pick EXPORT_SYMBOL over
EXPORT_SYMBOL_GPL here? It is your decision as the copyright
holder, but the default is often EXPORT_SYMBOL_GPL these
days, to make it clear that you don't expect closed source
drivers to plug in there.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/