linux-kernel - [PATCH] staging/goldfish: Add MTD dependency to KCONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1360277198-18246-1-git-send-email-peterhuewe@gmx.de>
Date:	Thu,  7 Feb 2013 23:46:38 +0100
From:	Peter Huewe <peterhuewe@....de>
To:	Randy Dunlap <rdunlap@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org,
	Yunhong Jiang <yunhong.jiang@...el.com>,
	Sheng Yang <sheng@...ux.intel.com>,
	"Mike A. Chan" <mikechan@...gle.com>,
	Xiaohui Xin <xiaohui.xin@...el.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Peter Huewe <peterhuewe@....de>
Subject: [PATCH] staging/goldfish: Add MTD dependency to KCONFIG

If CONFIG_MTD is not set goldfish_nand fails to compile with the
following linker warnings:

drivers/built-in.o: In function `goldfish_nand_remove':
goldfish_nand.c:(.text+0x6e7d0e): undefined reference to
`mtd_device_unregister'
drivers/built-in.o: In function `goldfish_nand_erase':
goldfish_nand.c:(.text+0x6e8ba2): undefined reference to
`mtd_erase_callback'
drivers/built-in.o: In function `goldfish_nand_init_device':
goldfish_nand.c:(.text+0x6e8eba): undefined reference to
`mtd_device_parse_register'

Reported-by: Randy Dunlap <rdunlap@...radead.org>
Signed-off-by: Peter Huewe <peterhuewe@....de>
---
@Randy: The contact info you're looking for is in CC of this mail.

 drivers/staging/goldfish/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/goldfish/Kconfig b/drivers/staging/goldfish/Kconfig
index d6c98d0..4e09460 100644
--- a/drivers/staging/goldfish/Kconfig
+++ b/drivers/staging/goldfish/Kconfig
@@ -7,6 +7,7 @@ config GOLDFISH_AUDIO
 config MTD_GOLDFISH_NAND
 	tristate "Goldfish NAND device"
 	depends on GOLDFISH
+	depends on MTD
 	help
 	  Drives the emulated NAND flash device on the Google Goldfish
 	  Android virtual device.
-- 
1.7.8.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/