linux-kernel - Re: [PATCH] clk: tegra: local arrays should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51148B8C.2000005@nvidia.com>
Date:	Fri, 8 Feb 2013 10:52:20 +0530
From:	Prashant Gaikwad <pgaikwad@...dia.com>
To:	Peter De Schrijver <pdeschrijver@...dia.com>
CC:	Stephen Warren <swarren@...dia.com>,
	Mike Turquette <mturquette@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: tegra: local arrays should be static

On Thursday 07 February 2013 10:00 PM, Peter De Schrijver wrote:
> cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
> clk-tegra30.c. Declare them static to avoid namespace polution.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@...dia.com>

Reviewed-by: Prashant Gaikwad <pgaikwad@...dia.com>

> ---
>   drivers/clk/tegra/clk-tegra30.c |   20 ++++++++++----------
>   1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
> index a163812..d169ef0 100644
> --- a/drivers/clk/tegra/clk-tegra30.c
> +++ b/drivers/clk/tegra/clk-tegra30.c
> @@ -1249,16 +1249,16 @@ static void __init tegra30_pmc_clk_init(void)
>   
>   }
>   
> -const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
> -				 "pll_p_cclkg", "pll_p_out4_cclkg",
> -				 "pll_p_out3_cclkg", "unused", "pll_x" };
> -const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
> -				  "pll_p_cclklp", "pll_p_out4_cclklp",
> -				  "pll_p_out3_cclklp", "unused", "pll_x",
> -				  "pll_x_out0" };
> -const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
> -			       "pll_p_out3", "pll_p_out2", "unused",
> -			       "clk_32k", "pll_m_out1" };
> +static const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
> +					"pll_p_cclkg", "pll_p_out4_cclkg",
> +					"pll_p_out3_cclkg", "unused", "pll_x" };
> +static const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
> +					 "pll_p_cclklp", "pll_p_out4_cclklp",
> +					 "pll_p_out3_cclklp", "unused", "pll_x",
> +					 "pll_x_out0" };
> +static const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
> +				      "pll_p_out3", "pll_p_out2", "unused",
> +				      "clk_32k", "pll_m_out1" };
>   
>   static void __init tegra30_super_clk_init(void)
>   {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/