linux-kernel - Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130208112027.GI8879@opensource.wolfsonmicro.com>
Date:	Fri, 8 Feb 2013 11:20:28 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Amit Daniel Kachhap <amit.daniel@...sung.com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Sangbeom Kim <sbkim73@...sung.com>,
	LiamGirdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at
 various places

On Wed, Feb 06, 2013 at 10:56:52AM +0800, Axel Lin wrote:

> Use &pdev->dev rather than iodev->dev for dev_err(), dev_warn() and dev_info().

It's not clear to me that this is actually an improvement, the pdev is
mostly just an internal Linux implementation detail so it's common to
use the physical device for MFD logging in order to help the user
understand what's causing the log message.

> Use &pdev->dev rather than iodev->dev for devm_kzalloc() and
> of_get_regulator_init_data(), this fixes memory leak.

This is a good fix though.  This sort of thing is one reason for
splitting out unrelated changes.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)