linux-kernel - Re: [PATCH v2 08/26] iommu, irq: Allocate irq_desc for dmar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <511563F6.1080009@redhat.com>
Date:	Fri, 08 Feb 2013 15:45:42 -0500
From:	Don Dutile <ddutile@...hat.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH v2 08/26] iommu, irq: Allocate irq_desc for dmar_msi with
 local node

On 02/08/2013 02:28 PM, Yinghai Lu wrote:
> iommu irq's irq_desc should be on local node ram.
>
> Fix the return value checking problem.
>
> create_irq() will return -1 when fail to allocate.
> create_irq_nr() will return 0 when fail to allocate.
>
> here only check !irq, so need to change it to use create_irq_nr instead.
>
> Signed-off-by: Yinghai Lu<yinghai@...nel.org>
> Cc: Joerg Roedel<joro@...tes.org>
> Cc: Donald Dutile<ddutile@...hat.com>
> ---
>   drivers/iommu/dmar.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
> index 174bb65..316b5a2 100644
> --- a/drivers/iommu/dmar.c
> +++ b/drivers/iommu/dmar.c
> @@ -1263,7 +1263,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu)
>   	if (iommu->irq)
>   		return 0;
>
> -	irq = create_irq();
> +	irq = create_irq_nr(0, iommu->node);
>   	if (!irq) {
>   		pr_err("IOMMU: no free vectors\n");
>   		return -EINVAL;
Good catch!

you can add my ack to it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/