linux-kernel - Re: [PATCH v2 26/26] PCI, x86, ACPI: Add ioapic hotplug support with acpi host bridge.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Feb 2013 14:35:54 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 26/26] PCI, x86, ACPI: Add ioapic hotplug support with
 acpi host bridge.

On Fri, Feb 8, 2013 at 1:24 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Fri, Feb 8, 2013 at 12:28 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>> We need to have ioapic setup before normal pci drivers.
>> otherwise other pci driver can not setup irq.
>>
>> Make ioapic built-in, so can call add/remove during host-bridge add/remove
>> the same as the booting path.
>>
>> Also need to make it depends on X86_IO_APIC.
>
> There are a lot of different things happening in this patch.  I'd
> prefer if they were split out so we can see what's happening.  For
> example, the Kconfig changes could be their own patch.  The removal of
> the PCI device table is worthy of mention and its own patch (if
> possible), since it's a pretty major change to how the driver binds to
> devices.

ok, will try to split it small patches..

also I'd like to leave you and Rafael to decide if we need to move that file to
drivers/acpi/pci_ioapic.c or something else.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/