[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20130209094753.555F03E2C66@localhost>
Date: Sat, 09 Feb 2013 09:47:53 +0000
From: Grant Likely <grant.likely@...retlab.ca>
To: Alex Courbot <acourbot@...dia.com>,
Linus Walleij <linus.walleij@...aro.org>
Cc: "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
"gnurou@...il.com" <gnurou@...il.com>,
Arnd Bergmann <arnd@...db.de>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Haojian Zhuang <haojian.zhuang@...aro.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 5/9] gpiolib: use gpio_chips list in gpiochip_find_base
On Wed, 6 Feb 2013 13:48:19 +0900, Alex Courbot <acourbot@...dia.com> wrote:
> On 02/06/2013 02:21 AM, Linus Walleij wrote:
> > This looks like it is preserving this userspace-sensitive semantic
> > so that dynamically added chips will still get the same assigned
> > numbers.
>
> It does (it should, at least), the assigned ranges should be strictly
> identical to the previous version. While testing I also made sure all
> chips had the same GPIO range.
>
> > But I want some guarantees, so state clearly in the commit
> > that any dynamically assigned chip will get the same base
> > address after this change as it got before it, and please take
> > this opportunity to add a comment stating that this search
> > method is vital for userspace ABIs, and must be preserved.
>
> Done. I will take the blame if something goes wrong. :)
Applied, thanks
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists