linux-kernel - Re: [PATCH] da9030_battery: include notifier.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Feb 2013 17:45:15 -0800
From:	Anton Vorontsov <anton@...msg.org>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Axel Lin <axel.lin@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] da9030_battery: include notifier.h

On Wed, Feb 06, 2013 at 03:09:59PM +0100, Michal Hocko wrote:
> Ohh, I have just noticed that this could be introduced by "mm: break
> circular include from linux/mmzone.h" in mm tree.
> Adding Andrew to CC.

The patch is legit, actually. So, I've applied it, thank you!

Anton

> On Wed 06-02-13 10:14:58, Michal Hocko wrote:
> > randconfig complains about:
> > drivers/power/da9030_battery.c:113: error: field ‘nb’ has incomplete type
> > 
> > because there is no direct include for notifier.h which defines
> > struct notifier_block.
> > 
> > Signed-off-by: Michal Hocko <mhocko@...e.cz>
> > ---
> >  drivers/power/da9030_battery.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/power/da9030_battery.c b/drivers/power/da9030_battery.c
> > index 94762e6..e8c5a39 100644
> > --- a/drivers/power/da9030_battery.c
> > +++ b/drivers/power/da9030_battery.c
> > @@ -22,6 +22,7 @@
> >  
> >  #include <linux/debugfs.h>
> >  #include <linux/seq_file.h>
> > +#include <linux/notifier.h>
> >  
> >  #define DA9030_FAULT_LOG		0x0a
> >  #define DA9030_FAULT_LOG_OVER_TEMP	(1 << 7)
> > -- 
> > 1.7.10.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> Michal Hocko
> SUSE Labs
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/