linux-kernel - Re: [PATCH v2] gpio: devm_gpio_* support should not depend on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Feb 2013 07:46:30 +0300
From:	Max Filippov <jcmvbkbc@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Shawn Guo <shawn.guo@...aro.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: devm_gpio_* support should not depend on GPIOLIB

On Sat, Jan 19, 2013 at 2:33 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Fri, Jan 18, 2013 at 8:57 AM, Shawn Guo <shawn.guo@...aro.org> wrote:
>
>> Some architectures (e.g. blackfin) provide gpio API without requiring
>> GPIOLIB support (ARCH_WANT_OPTIONAL_GPIOLIB).  devm_gpio_* functions
>> should also work for these architectures, since they do not really
>> depend on GPIOLIB.
>>
>> Add a new option GPIO_DEVRES (enabled by default) to control the build
>> of devres.c.  It also removes the empty version of devm_gpio_*
>> functions for !GENERIC_GPIO build from linux/gpio.h, and moves the
>> function declarations from asm-generic/gpio.h into linux/gpio.h.
>>
>> Signed-off-by: Shawn Guo <shawn.guo@...aro.org>
>
> OK I removed the old version of the patch and pushed this instead.

Hi,

this patch causes the following errors for xtensa defconfig build:

include/asm-generic/gpio.h:265:2: error: implicit declaration of
function '__gpio_get_value' [-Werror=implicit-function-declaration]
include/asm-generic/gpio.h:271:2: error: implicit declaration of
function '__gpio_set_value' [-Werror=implicit-function-declaration]
include/linux/gpio.h:60:90: error: redefinition of 'gpio_cansleep'
include/linux/gpio.h:62:2: error: implicit declaration of function
'__gpio_cansleep' [-Werror=implicit-function-declaration]
include/linux/gpio.h:67:2: error: implicit declaration of function
'__gpio_to_irq' [-Werror=implicit-function-declaration]
drivers/gpio/devres.c:26:2: error: implicit declaration of function
'gpio_free' [-Werror=implicit-function-declaration]
drivers/gpio/devres.c:60:2: error: implicit declaration of function
'gpio_request' [-Werror=implicit-function-declaration]
drivers/gpio/devres.c:90:2: error: implicit declaration of function
'gpio_request_one' [-Werror=implicit-function-declaration]

-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/