linux-kernel - Re: [PATCH v2 00/26] x86, irq: support ioapic device hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130211093417.GC23932@gmail.com>
Date:	Mon, 11 Feb 2013 10:34:17 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 00/26] x86, irq: support ioapic device hotplug

* Yinghai Lu <yinghai@...nel.org> wrote:

> Hi,
> 
> Current x86 code does not support iapic hotplug yet.

Please give a better high-level description: outline how an 
IO-APIC will be hotplugged physically and what changes the 
user will experience.

That needs at least 2 paragraphs, not one cursory sentence. Then 
should come technical descriptions - but even those need 
improvements, please first explain the current status quo, then 
explain how that is inadequate for IO-APIC hot-plugging, *then* 
only explain what you are doing in the patch ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/