linux-kernel - Re: [PATCH] regmap: debugfs: Add a registers `range' file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130211131641.GG4607@opensource.wolfsonmicro.com>
Date:	Mon, 11 Feb 2013 13:16:41 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] regmap: debugfs: Add a registers `range' file

On Mon, Feb 11, 2013 at 10:52:23AM +0000, Dimitris Papastamos wrote:

> +struct regmap_reg_range  {
> +	unsigned int start;
> +	unsigned int end;
> +	unsigned int attr;
> +};

All we ever do with this struct is

> +		r.start = c->base_reg;
> +		r.end = c->max_reg;
> +		r.attr = c->reg_attr;

pack it with the contents of a cache entry.  Why not just use the cache
entry directly?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)