linux-kernel - Re: query about create_mnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130211141028.GJ4503@ZenIV.linux.org.uk>
Date:	Mon, 11 Feb 2013 14:10:28 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Rajat Sharma <fs.rajat@...il.com>
Cc:	linux-fsdevel@...r.kernel.org,
	linux-kernel-mail <linux-kernel@...r.kernel.org>
Subject: Re: query about create_mnt_ns

On Mon, Feb 11, 2013 at 05:44:29PM +0530, Rajat Sharma wrote:
> Hi,
> 
> I was looking at implementation of init_mount_tree() function and
> found a discrepancy in list manipulation of mnt_namsespace and
> vfsmount across kernel version 2.6.30. Up till kernel version
> 2.6.30.x, vfsmount structure was added to the list headed by
> mnt_namespace structure just allocated:
> 
> list_add(&mnt->mnt_list, &ns->list);
> 
> Beyond that with the introduction of function create_mnt_ns(), it does
> reverse of previous behavior:
> 
> list_add(&new_ns->list, &mnt->mnt_list);
> 
> i.e. it is adding new mnt_namespace to the vfsmount list. Is this the
> expected behavior? i.e. do we want to maintain list of namespaces per
> mount? Please let me know if I am missing something here.

The fact that if A and B are both empty, list_add(A, B) and list_add(B, A)
will do exactly the same thing ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/