| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <s5ha9raq33b.wl%tiwai@suse.de> Date: Mon, 11 Feb 2013 16:31:36 +0100 From: Takashi Iwai <tiwai@...e.de> To: Denis Efremov <yefremov.denis@...il.com> Cc: Bill Pemberton <wfp5p@...ginia.edu>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [ALSA] sound: rme32.c irq enabling after spin_lock_irq At Mon, 11 Feb 2013 19:04:06 +0400, Denis Efremov wrote: > > According to the other code in this driver and similar > code in rme96 it seems, that spin_lock_irq in > snd_rme32_capture_close function should be paired > with spin_unlock_irq. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Denis Efremov <yefremov.denis@...il.com> Thanks, applied (with Cc to stable, too). Takashi > --- > sound/pci/rme32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c > index 2450663..0ecd410 100644 > --- a/sound/pci/rme32.c > +++ b/sound/pci/rme32.c > @@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream) > spin_lock_irq(&rme32->lock); > rme32->capture_substream = NULL; > rme32->capture_periodsize = 0; > - spin_unlock(&rme32->lock); > + spin_unlock_irq(&rme32->lock); > return 0; > } > > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists