linux-kernel - Re: [PATCH] ALSA: ali5451: remove irq enabling in pointer callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4nhiq1h3.wl%tiwai@suse.de>
Date:	Mon, 11 Feb 2013 17:06:32 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Denis Efremov <yefremov.denis@...il.com>
Cc:	Bill Pemberton <wfp5p@...ginia.edu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: ali5451: remove irq enabling in pointer callback

At Mon, 11 Feb 2013 19:49:48 +0400,
Denis Efremov wrote:
> 
> snd_ali_pointer function is called with local
> interrupts disabled. However it seems very strange to
> reenable them in such way.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Denis Efremov <yefremov.denis@...il.com>

Thanks, applied now.


Takashi

> ---
>  sound/pci/ali5451/ali5451.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
> index 136a393..e760af9 100644
> --- a/sound/pci/ali5451/ali5451.c
> +++ b/sound/pci/ali5451/ali5451.c
> @@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)
>  
>  	spin_lock(&codec->reg_lock);
>  	if (!pvoice->running) {
> -		spin_unlock_irq(&codec->reg_lock);
> +		spin_unlock(&codec->reg_lock);
>  		return 0;
>  	}
>  	outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));
> -- 
> 1.8.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/