linux-kernel - Re: [PATCH] mmc: mmc_spi: Fix return value evaluation of irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Feb 2013 11:49:11 -0500
From:	Chris Ball <cjb@...top.org>
To:	Roland Stigge <stigge@...com.de>
Cc:	plagnioj@...osoft.com, grant.likely@...retlab.ca,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mmc: mmc_spi: Fix return value evaluation of irq_of_parse_and_map()

Hi,

On Wed, Jan 30 2013, Roland Stigge wrote:
> When irq_of_parse_and_map() returns an error, it does as zero. But in
> mmc_spi_get_pdata(), the error return case is compared against NO_IRQ. This
> might work where NO_IRQ is zero (defaults to zero when undefined, as on MIPS)
> but not where NO_IRQ is sth. different, e.g. on ARM, where it is -1.
>
> This patch changes to comparison with 0 which is the error return value of
> irq_of_parse_and_map(). 
>
> Tested on ARM that mmc_spi is working now.
>
> Signed-off-by: Roland Stigge <stigge@...com.de>
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index 1534b58..d720b5e 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -146,7 +146,7 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
>  		oms->pdata.get_ro = of_mmc_spi_get_ro;
>  
>  	oms->detect_irq = irq_of_parse_and_map(np, 0);
> -	if (oms->detect_irq != NO_IRQ) {
> +	if (oms->detect_irq != 0) {
>  		oms->pdata.init = of_mmc_spi_init;
>  		oms->pdata.exit = of_mmc_spi_exit;
>  	} else {

Thanks, pushed to mmc-next for 3.9.

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/