linux-kernel - Re: [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51193476.8020509@wwwdotorg.org>
Date:	Mon, 11 Feb 2013 11:12:06 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Joe Perches <joe@...ches.com>
CC:	arm@...nel.org, linux-tegra@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section

On 02/11/2013 11:04 AM, Joe Perches wrote:
> On Mon, 2013-02-11 at 11:01 -0700, Stephen Warren wrote:
>> On 02/11/2013 10:56 AM, Joe Perches wrote:
>>> On Mon, 2013-02-11 at 10:51 -0700, Stephen Warren wrote:
>>>> From: Stephen Warren <swarren@...dia.com>
>>>>
>>>> The intent is to ensure that all Tegra-related patches are sent to the
>>>> linux-tegra@ mailing list, so people can keep up-to-date on all misc
>>>> driver changes.
>>>>
>>>> Doing this with a keyword is far simpler and more compact than listing
>>>> all Tegra-related drivers, even if wildcards were used.
>>>>
>>>> Words such as integrate or integrator are common. Ensure the character
>>>> right before "tegra" isn't a-z (case-insensitive), to make sure the
>>>> keyword doesn't match those.
>>>>
>>>> Cc: Joe Perches <joe@...ches.com>
>>>> Signed-off-by: Stephen Warren <swarren@...dia.com>
>>>> ---
>>>>  MAINTAINERS |    4 +---
>>>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index b98c89b..10e9b31 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -7829,9 +7829,7 @@ L:	linux-tegra@...r.kernel.org
>>>>  Q:	http://patchwork.ozlabs.org/project/linux-tegra/list/
>>>>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
>>>>  S:	Supported
>>>> -F:	arch/arm/mach-tegra
>>>> -F:	arch/arm/boot/dts/tegra*
>>>> -F:	arch/arm/configs/tegra_defconfig
>>>> +K:	(?i)[^a-z]tegra
>>>>  
>>>>  TEHUTI ETHERNET DRIVER
>>>>  M:	Andy Gospodarek <andy@...yhouse.net>
>>>
>>> It's probably not a good idea to remove
>>> any of the F: lines as there are files
>>> that could get modified in those paths
>>> without any tegra word in the patch.
>>
>> At least for those F: lines that exist already and are removed above,
>> the keyword will match their filename, so there's no issue here.
>>
> 
> Not every use of get_maintainers is by patch.
> 
> ./scripts/get_maintainer.pl -f arch/arm/mach-tegra
> 
> wouldn't match anything.

That's annoying; it kinda defeats the whole purpose of this patch then.

The way this patch works out with a patch is because the file-names are
matched against the keywords since they appear in the patch. A solution
to the issue you raise would be to do the same in -f mode, by adding an
explicit pass to check the filenames that are found against MAINTAINERS
too. Do you have any objection to that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/