linux-kernel - Re: [PATCH 2/2] zram: gather statistics in a unique file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Feb 2013 21:41:17 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Davidlohr Bueso <davidlohr.bueso@...com>
Cc:	linux-kernel@...r.kernel.org, Nitin Gupta <ngupta@...are.org>
Subject: Re: [PATCH 2/2] zram: gather statistics in a unique file

On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote:
> Instead of having one sysfs file per zram statistic, group them all
> in a single, reader-friendly, 'statistics' file. This not only reduces
> code but is also makes it easier to visualize. The new file looks like:
> 
> Number of reads:        24
> Number of writes:       1055
> Invalid IO:             0
> Notify free:            0
> Zero pages:             1042
> Orig data size:         49152 bytes
> Compressed data:        838 bytes
> Total memory used:      53248 bytes
> 
> Signed-off-by: Davidlohr Bueso <davidlohr.bueso@...com>

No, please, the rule for sysfs is "one value per file", not files with
lots of data that you need to parse.

If you want to do something like this, then do it in debugfs, but NEVER
in sysfs.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/