linux-kernel - Re: [PATCH] cpufreq: 64bit divide in intel_pstate_calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1987087.S730EjTqbJ@vostro.rjw.lan>
Date:	Mon, 11 Feb 2013 20:42:41 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Artem Savkov <artem.savkov@...il.com>
Cc:	Dirk Brandewie <dirk.brandewie@...il.com>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: 64bit divide in intel_pstate_calc_busy()

On Monday, February 11, 2013 11:24:08 PM Artem Savkov wrote:
> intel_pstate.c won't compile on i686 because of a linking error:
> drivers/cpufreq/intel_pstate.c:459: undefined reference to `__udivdi3'
> 
> Signed-off-by: Artem Savkov <artem.savkov@...il.com>

I've just applied an equivalent patch from Dirk.

Thanks,
Rafael


> ---
>  drivers/cpufreq/intel_pstate.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 86ad482..dc43208 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -456,7 +456,9 @@ static inline void intel_pstate_calc_busy(struct cpudata *cpu,
>  	core_pct = div64_u64(sample->aperf * 100, sample->mperf);
>  	sample->freq = cpu->pstate.turbo_pstate * core_pct * 1000;
>  
> -	sample->core_pct_busy = sample->pstate_pct_busy * core_pct / 100;
> +	sample->core_pct_busy = div64_u64(
> +					sample->pstate_pct_busy * core_pct,
> +					100);
>  }
>  
>  static inline void intel_pstate_sample(struct cpudata *cpu)
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/