linux-kernel - [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Feb 2013 13:48:43 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christine Caulfield <ccaulfie@...hat.com>,
	David Teigland <teigland@...hat.com>
cc:	cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is
 disabled

CONFIG_IP_SCTP relies on being able to select things like CONFIG_CRC32C to 
build.  Thus, nothing should be selecting CONFIG_IP_SCTP that does not 
meet its requirements.

For example, if CONFIG_EXPERIMENTAL is disabled and CONFIG_DLM is enabled, 
the build fails at link time:

	net/built-in.o: In function `sctp_crc32c':
	include/net/sctp/checksum.h:51: undefined reference to `crc32c'
	include/net/sctp/checksum.h:51: undefined reference to `crc32c'
	include/net/sctp/checksum.h:51: undefined reference to `crc32c'
	include/net/sctp/checksum.h:51: undefined reference to `crc32c'
	include/net/sctp/checksum.h:51: undefined reference to `crc32c'
	net/built-in.o:include/net/sctp/checksum.h:51: more undefined references to `crc32c' follow

Fix this by making CONFIG_DLM depend on CONFIG_EXPERIMENTAL so that 
CONFIG_IP_SCTP properly builds.

Signed-off-by: David Rientjes <rientjes@...gle.com>
---
 fs/dlm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/dlm/Kconfig b/fs/dlm/Kconfig
--- a/fs/dlm/Kconfig
+++ b/fs/dlm/Kconfig
@@ -2,6 +2,7 @@ menuconfig DLM
 	tristate "Distributed Lock Manager (DLM)"
 	depends on INET
 	depends on SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n)
+	depends on EXPERIMENTAL
 	select IP_SCTP
 	help
 	A general purpose distributed lock manager for kernel or userspace
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/