linux-kernel - Re: [PATCH 08/16] cris idle: delete idle and pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130211084248.GY23529@axis.com>
Date:	Mon, 11 Feb 2013 09:42:48 +0100
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Len Brown <lenb@...nel.org>
Cc:	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Len Brown <len.brown@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-cris-kernel <linux-cris-kernel@...s.com>
Subject: Re: [PATCH 08/16] cris idle: delete idle and pm_idle

On Sun, Feb 10, 2013 at 06:58:15AM +0100, Len Brown wrote:
> From: Len Brown <len.brown@...el.com>
> 
> pm_idle() and idle() served no purpose on cris --
> invoke default_idle() directly.
> 
> Signed-off-by: Len Brown <len.brown@...el.com>
> Cc: linux-cris-kernel@...s.com

Looks good!

Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>

> ---
>  arch/cris/kernel/process.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/arch/cris/kernel/process.c b/arch/cris/kernel/process.c
> index 7f65be6..104ff4d 100644
> --- a/arch/cris/kernel/process.c
> +++ b/arch/cris/kernel/process.c
> @@ -54,11 +54,6 @@ void enable_hlt(void)
>  
>  EXPORT_SYMBOL(enable_hlt);
>   
> -/*
> - * The following aren't currently used.
> - */
> -void (*pm_idle)(void);
> -
>  extern void default_idle(void);
>  
>  void (*pm_power_off)(void);
> @@ -77,16 +72,12 @@ void cpu_idle (void)
>  	while (1) {
>  		rcu_idle_enter();
>  		while (!need_resched()) {
> -			void (*idle)(void);
>  			/*
>  			 * Mark this as an RCU critical section so that
>  			 * synchronize_kernel() in the unload path waits
>  			 * for our completion.
>  			 */
> -			idle = pm_idle;
> -			if (!idle)
> -				idle = default_idle;
> -			idle();
> +			default_idle();
>  		}
>  		rcu_idle_exit();
>  		schedule_preempt_disabled();
> -- 
> 1.8.1.3.535.ga923c31

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/