linux-kernel - Re: [PATCH] lpc_sch: Accomodate partial population of the MFD devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130212103455.GG20996@sortiz-mobl>
Date:	Tue, 12 Feb 2013 11:34:55 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Darren Hart <dvhart@...ux.intel.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Denis Turischev <denis@...pulab.co.il>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] lpc_sch: Accomodate partial population of the MFD devices

Hi Darren,

On Fri, Feb 08, 2013 at 03:20:36PM -0800, Darren Hart wrote:
> The current probe aborts if any of the 3 base address registers are
> disabled. On a TunnelCreek system I am working on, this resulted in the
> SMBIOS and GPIO devices being removed when it couldn't read the base
> address for the watchdog timer.
> 
> This patch accommodates partial population of the lpc_sch_cells array and
> only aborts if all the base address registers are disabled. A max size
> array is allocated and the individual device cells are added to it after
> their base addresses are successfully determined. This simplifies the
> code a bit by removing the need for the separate tunnelcreek cells array
> and combining some of the add/remove logic.
> 
> Signed-off-by: Darren Hart <dvhart@...ux.intel.com>
> Cc: Grant Likely <grant.likely@...retlab.ca>,
> Cc: Denis Turischev <denis@...pulab.co.il>,
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Signed-off-by: Darren Hart <dvhart@...ux.intel.com>
> ---
>  drivers/mfd/lpc_sch.c | 148 ++++++++++++++++++++++++--------------------------
>  1 file changed, 70 insertions(+), 78 deletions(-)
Patch applied, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/