| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1360666720-19006-4-git-send-email-andriy.shevchenko@linux.intel.com> Date: Tue, 12 Feb 2013 12:58:36 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Vinod Koul <vinod.koul@...el.com>, linux-kernel@...r.kernel.org, Viresh Kumar <viresh.kumar@...aro.org> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Linus Walleij <linus.walleij@...aro.org>, linux-arm-kernel@...ts.infradead.org Subject: [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking I have not checked the code but there is a possibility that custom pool->lock is not needed at all due to dma_pool contains it's own lock. Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Linus Walleij <linus.walleij@...aro.org> Cc: linux-arm-kernel@...ts.infradead.org --- drivers/dma/coh901318_lli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/coh901318_lli.c b/drivers/dma/coh901318_lli.c index 3e96610..702112d 100644 --- a/drivers/dma/coh901318_lli.c +++ b/drivers/dma/coh901318_lli.c @@ -61,7 +61,7 @@ coh901318_lli_alloc(struct coh901318_pool *pool, unsigned int len) dma_addr_t phy; if (len == 0) - goto err; + return NULL; spin_lock(&pool->lock); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists