linux-kernel - RE: [PATCH V2] Regulator: Reorder the min max assignment in the sequence of regulator_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DC88CAD03C0052499C1907B327FC63229B9912@DBDE01.ent.ti.com>
Date:	Tue, 12 Feb 2013 11:11:41 +0000
From:	"J, KEERTHY" <j-keerthy@...com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>
Subject: RE: [PATCH V2] Regulator: Reorder the min max assignment in the
 sequence of regulator_set_voltage function

Hi Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
> Sent: Monday, February 11, 2013 10:35 PM
> To: J, KEERTHY
> Cc: linux-kernel@...r.kernel.org; lgirdwood@...il.com
> Subject: Re: [PATCH V2] Regulator: Reorder the min max assignment in
> the sequence of regulator_set_voltage function
> 
> On Mon, Feb 11, 2013 at 12:19:34PM +0530, J Keerthy wrote:
> 
> > The min and max values for regulators are getting assigned before
> > actually the voltage is set. So making sure that min and max values
> > are assigned only if the voltage is successfully set else keeping the
> > last successfully set voltage's min and max values.
> 
> > This is boot tested on OMAP4430 and OMAP4460 boards.
> 
> This seems fine but doesn't apply against topic/core or -next, can you
> please regenerate against topic/core and resend?

I pulled the topic/core on to my tree. Seems like the exact fix has
Already been made in that branch :-P.

commit 92d7a55879c01b30349045501108e775655a4b92
Author: Paolo Pisati <paolo.pisati@...onical.com>
Date:   Thu Dec 13 10:13:00 2012 +0100

    regulator: core: if voltage scaling fails, restore original voltage values

It is already taken care. 
> 
> > V2: Fixed comment from Mark. Introduced local variables to hold
> > current min and max values.
> 
> Don't include things like this in the changelog, include them after the
> --- as covered in SubmittingPatches.

Ok

Thanks,
Keerthy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/