linux-kernel - Re: [PATCH v2] gpio: devm_gpio_* support should not depend on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYpAqXQY-K9euyiBaEei2+=2VbNeCaD0-ThJWbWX3MN-Q@mail.gmail.com>
Date:	Tue, 12 Feb 2013 13:35:29 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Max Filippov <jcmvbkbc@...il.com>
Cc:	Shawn Guo <shawn.guo@...aro.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: devm_gpio_* support should not depend on GPIOLIB

On Mon, Feb 11, 2013 at 5:50 PM, Max Filippov <jcmvbkbc@...il.com> wrote:

> FWIW I see that the issue is caused by building drivers/gpio/devres.c
> with CONFIG_GPIOLIB=n. Should I just turn GPIO_DEVRES off too?

Hm. Shawn just added:

+config GPIO_DEVRES
+       def_bool y
+       depends on HAS_IOMEM

Can you please patch the last line like so:

        depends on (HAS_IOMEM && GPIOLIB)

I think that's the actual problem... Maybe also move this
config option below the GPIOLIB entry. Or move it under
the #if GPIOLIB even.

Can you send a patch that works for you?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/