linux-kernel - Re: [PATCH] drm: missing idr_preload_end in drm_gem_flink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130212172820.GC7348@htj.dyndns.org>
Date:	Tue, 12 Feb 2013 09:28:20 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Artem Savkov <artem.savkov@...il.com>
Cc:	David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] drm: missing idr_preload_end in drm_gem_flink_ioctl

(cc'ing Andrew)

Hello,

On Sun, Feb 10, 2013 at 03:49:05PM +0400, Artem Savkov wrote:
> Added missing idr_preload_end calls in drm_gem_flink_ioctl().
> Without those preemption stays disabled resulting in lots of "scheduling while
> atomic" BUGs.
> 
> Introduced in 4e486fae707d9a79c76f1be6dcacffc4a721cc1b (linux-next.git)
> 
> Signed-off-by: Artem Savkov <artem.savkov@...il.com>
> ---
>  drivers/gpu/drm/drm_gem.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 6577514..f1700ef 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -456,6 +456,7 @@ drm_gem_flink_ioctl(struct drm_device *dev, void *data,
>  		obj->name = ret;
>  		args->name = (uint64_t) obj->name;
>  		spin_unlock(&dev->object_name_lock);
> +		idr_preload_end();
>  
>  		if (ret < 0)
>  			goto err;
> @@ -465,6 +466,7 @@ drm_gem_flink_ioctl(struct drm_device *dev, void *data,
>  	} else {
>  		args->name = (uint64_t) obj->name;
>  		spin_unlock(&dev->object_name_lock);
> +		idr_preload_end();
>  		ret = 0;

Oops, sorry about that.

 Acked-by: Tejun Heo <tj@...nel.org>

Andrew, the original patch can be found at

 http://article.gmane.org/gmane.linux.kernel/1439101/raw

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/