linux-kernel - Re: [PATCH 1/2] stop_machine: check work->done while handling enqueued works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130212173737.GF7348@htj.dyndns.org>
Date:	Tue, 12 Feb 2013 09:37:37 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Hillf Danton <dhillf@...il.com>
Cc:	Namhyung Kim <namhyung@...nel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] stop_machine: check work->done while handling
 enqueued works

On Sun, Feb 10, 2013 at 01:22:43PM +0800, Hillf Danton wrote:
> In cpu_stopper_thread(), @work->done may be NULL if the cpu stop work
> is queued from stop_one_cpu_nowait(); however, cpu_stopper_thread()
> updates @done->ret without checking whether @done exists or not when
> the work function fails.
> 
> While this can lead to oops, the only current user of
> stop_one_cpu_nowait() - active_load_balance_cpu_stop() - always
> returns 0 and thus there's no in-kernel user which triggers this bug.
> 
> Fix it by checking whether @done exists before updating @done->ret.
> 
> Thanks Tejun for sharing commit message.
> 
> Signed-off-by: Hillf Danton <dhillf@...il.com>
> Reviewed-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Tejun Heo <tj@...nel.org>

Andrew, can you please take this?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/