| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1360693404-61617-1-git-send-email-tim.gardner@canonical.com> Date: Tue, 12 Feb 2013 11:23:24 -0700 From: Tim Gardner <tim.gardner@...onical.com> To: linux-kernel@...r.kernel.org Cc: Tim Gardner <tim.gardner@...onical.com>, Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org Subject: [PATCH linux-next] jbd: start_this_handle(): remove kfree() redundant null check smatch analysis: fs/jbd/transaction.c:236 start_this_handle() info: redundant null check on new_transaction calling kfree() Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Jan Kara <jack@...e.cz> Cc: linux-ext4@...r.kernel.org Signed-off-by: Tim Gardner <tim.gardner@...onical.com> --- fs/jbd/transaction.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c index 071d690..ee40b4e 100644 --- a/fs/jbd/transaction.c +++ b/fs/jbd/transaction.c @@ -232,8 +232,7 @@ repeat_locked: lock_map_acquire(&handle->h_lockdep_map); out: - if (unlikely(new_transaction)) /* It's usually NULL */ - kfree(new_transaction); + kfree(new_transaction); return ret; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists