| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Feb 2013 14:44:14 -0500 (EST) From: "nyc@...omorphy.com" <nyc@...omorphy.com> To: Tim Gardner <tim.gardner@...onical.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH linux-next] hugetlbfs: hugetlbfs_fill_super(): remove kfree() redundant null check Acked-by: Nadia Yvette Chambers <nyc@...omorphy.com> On February 12, 2013 at 1:17 PM Tim Gardner <tim.gardner@...onical.com> wrote: > smatch analysis: > > fs/hugetlbfs/inode.c:883 hugetlbfs_fill_super() info: redundant null check on > sbinfo->spool calling kfree() > > Cc: Nadia Yvette Chambers <nyc@...omorphy.com> > Signed-off-by: Tim Gardner <tim.gardner@...onical.com> > --- > fs/hugetlbfs/inode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 78bde32..e2e36ef 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -879,8 +879,7 @@ hugetlbfs_fill_super(struct super_block *sb, void *data, > int silent) > goto out_free; > return 0; > out_free: > - if (sbinfo->spool) > - kfree(sbinfo->spool); > + kfree(sbinfo->spool); > kfree(sbinfo); > return -ENOMEM; > } > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists