linux-kernel - Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1302121207250.25566@chino.kir.corp.google.com>
Date:	Tue, 12 Feb 2013 12:13:24 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Steven Whitehouse <swhiteho@...hat.com>,
	Christine Caulfield <ccaulfie@...hat.com>,
	David Teigland <teigland@...hat.com>, cluster-devel@...hat.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Michal Marek <mmarek@...e.cz>
Subject: Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is
 disabled

On Tue, 12 Feb 2013, Linus Torvalds wrote:

> On Tue, Feb 12, 2013 at 1:50 AM, Steven Whitehouse <swhiteho@...hat.com> wrote:
> >
> > That doesn't seem right to me... DLM has not been experimental for a
> > long time now. Why not just select CRC32 in addition to IP_SCTP ?
> 
> Hmm. IP_SCTP already does a "select libcrc32c". So why doesn't that
> end up working?
> 

Kconfig won't select things that CONFIG_IP_SCTP select unless its "depends 
on" are satisfied, which is why I made CONFIG_DLM depend on 
CONFIG_EXPERIMENTAL.

Steven says DLM hasn't been experimental for a long time; sorry, but if an 
option you select is experimental then you're experimental as well.

If you'd like to push a patch that removes EXPERIMENTAL from IP_SCTP to 
David Miller, that works too.  But that is a completely separate topic 
from dlm.  For 3.8, I suggest respecting CONFIG_IP_SCTP's requirements and 
then removing EXPERIMENTAL from both if the networking guys agree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/