linux-kernel - Re: [3.8-rc7] PCI hotplug wakeup oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10651269.S7JAXTfMuy@vostro.rjw.lan>
Date:	Tue, 12 Feb 2013 22:00:22 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Tejun Heo <tj@...nel.org>, Daniel J Blueman <daniel@...ra.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Yijing Wang <wangyijing@...wei.com>
Subject: Re: [3.8-rc7] PCI hotplug wakeup oops

On Tuesday, February 12, 2013 12:50:38 PM Tejun Heo wrote:
> Hey, Rafael.
> 
> On Tue, Feb 12, 2013 at 09:53:08PM +0100, Rafael J. Wysocki wrote:
> > This looks fishy, but I wonder if Tejun has any ideas.
> > 
> > Tejun, can you please have a look at the call trace below?  It looks like
> > the workqueues code is involved heavily.
> > > 
> > > kworker/0:0/4 is trying to acquire lock:
> > >  (name){++++.+}, at: [<ffffffff8105ac70>] flush_workqueue+0x0/0x4d0
> > > 
> > > but task is already holding lock:
> > >  (name){++++.+}, at: [<ffffffff8105c7e0>] process_one_work+0x160/0x4e0
> 
> It's basically saying that a work item is trying to flush the
> workqueue it's currently executing on, at least in lockdep's eyes.
> 
> > > stack backtrace:
> > > Pid: 4, comm: kworker/0:0 Not tainted 3.8.0-rc7-ninja+ #21
> > > Call Trace:
> > >  [<ffffffff81090213>] validate_chain.isra.33+0xda3/0x1240
> > >  [<ffffffff8109113c>] __lock_acquire+0x3ac/0xb30
> > >  [<ffffffff81091d8a>] lock_acquire+0x5a/0x70
> > >  [<ffffffff8105ad58>] flush_workqueue+0xe8/0x4d0
> > >  [<ffffffff8105b1c8>] drain_workqueue+0x68/0x1f0
> > >  [<ffffffff8105b363>] destroy_workqueue+0x13/0x160
> 
> And the flush is from workqueue destruction
> 
> > >  [<ffffffff8125ad0a>] pciehp_release_ctrl+0x3a/0x90
> > >  [<ffffffff81257ca5>] pciehp_remove+0x25/0x30
> > >  [<ffffffff81251f72>] pcie_port_remove_service+0x52/0x70
> > >  [<ffffffff81302217>] __device_release_driver+0x77/0xe0
> > >  [<ffffffff813022a9>] device_release_driver+0x29/0x40
> > >  [<ffffffff81301cb1>] bus_remove_device+0xf1/0x140
> > >  [<ffffffff812ff847>] device_del+0x127/0x1c0
> > >  [<ffffffff812ff8f1>] device_unregister+0x11/0x20
> > >  [<ffffffff81252125>] remove_iter+0x35/0x40
> > >  [<ffffffff812fe716>] device_for_each_child+0x36/0x70
> > >  [<ffffffff812526c1>] pcie_port_device_remove+0x21/0x40
> > >  [<ffffffff81252908>] pcie_portdrv_remove+0x28/0x50
> > >  [<ffffffff81246cb1>] pci_device_remove+0x41/0xc0
> > >  [<ffffffff81302217>] __device_release_driver+0x77/0xe0
> > >  [<ffffffff813022a9>] device_release_driver+0x29/0x40
> > >  [<ffffffff81301cb1>] bus_remove_device+0xf1/0x140
> > >  [<ffffffff812ff847>] device_del+0x127/0x1c0
> > >  [<ffffffff812ff8f1>] device_unregister+0x11/0x20
> > >  [<ffffffff81241b74>] pci_stop_bus_device+0xb4/0xc0
> > >  [<ffffffff81241af5>] pci_stop_bus_device+0x35/0xc0
> > >  [<ffffffff81241cd1>] pci_stop_and_remove_bus_device+0x11/0x20
> > >  [<ffffffff81259021>] pciehp_unconfigure_device+0x91/0x190
> > >  [<ffffffff81258921>] pciehp_disable_slot+0x71/0x220
> > >  [<ffffffff81258bb6>] pciehp_power_thread+0xe6/0x110
> > >  [<ffffffff8105c84a>] process_one_work+0x1ca/0x4e0
> 
> running from a workqueue which probably is at least transitively
> related to the workqueue being destroyed.  Does this lead to an actual
> deadlock?

Might be.  I need to have a deeper look at things in the acpiphp land.

Daniel, I'm quite sure it isn't related to the addition of the pci_pme_active()
call.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/