linux-kernel - Re: compositing broken in -next (idr bug)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <511ABB5E.2090301@suse.cz>
Date:	Tue, 12 Feb 2013 22:59:58 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Tejun Heo <tj@...nel.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: compositing broken in -next (idr bug)

On 02/12/2013 10:58 PM, Tejun Heo wrote:
> Hello, Jiri.
> 
> On Tue, Feb 12, 2013 at 10:55:37PM +0100, Jiri Slaby wrote:
>> this commit in -next causes my KDE to get stuck while starting. I see
>> only the splash screen. If I disable effects by alt-shift-f12, it continues.
>>
>> I bisected it to this commit:
>> commit 430440fce7da4ad52c2af06a04a5132e5d19faaf
>> Author: Tejun Heo <tj@...nel.org>
>> Date:   Thu Feb 7 12:31:37 2013 +1100
>>
>>     drm: convert to idr_alloc()
>>
>>
>> More concretely to the change in drm_gem_flink_ioctl. If I revert solely
>> that one, it works again. Maybe I'm blind, but I do not see why...
>>
>> Well I see a bug in there, but that is not the root cause -- there is a
>> missing call to idr_preload_end. Of course, that one only leaves
>> preemption disabled forever.
> 
> Fix for this bug is already queued in -mm.
> 
>   http://article.gmane.org/gmane.linux.kernel/1439101/raw
> 
> But you're saying that adding the missing idr_preload_end() doesn't
> make the problem go away, right?

Yeah, right. I had to revert the whole hunk...

-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/