linux-kernel - Re: [PATCH 2/5] perf, x86: Basic Haswell PMU support v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130213081636.GA4542@gmail.com>
Date:	Wed, 13 Feb 2013 09:16:36 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org, eranian@...gle.com,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/5] perf, x86: Basic Haswell PMU support v4


* Andi Kleen <andi@...stfloor.org> wrote:

> +static int hsw_hw_config(struct perf_event *event)
> +{
> +	int ret = intel_pmu_hw_config(event);
> +
> +	if (ret)
> +		return ret;
> +	if (!boot_cpu_has(X86_FEATURE_RTM) && !boot_cpu_has(X86_FEATURE_HLE))
> +		return 0;
> +	event->hw.config |= event->attr.config & (HSW_INTX|HSW_INTX_CHECKPOINTED);
> +
> +	/*
> +	 * INTX/INTX-CP do not play well with PEBS or ANY thread mode.
> +	 */
> +	if ((event->hw.config & (HSW_INTX|HSW_INTX_CHECKPOINTED)) &&
> +	     ((event->hw.config & ARCH_PERFMON_EVENTSEL_ANY) ||
> +	      event->attr.precise_ip > 0))
> +		return -EOPNOTSUPP;

Please explain it more verbosely in the comment what 'do not 
play well' means and why it necessiates a -EOPNOTSUPP reply.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/