linux-kernel - Re: [PATCH] avr32: atmel_default_console_device depends on CONFIG_SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130212234921.GA11388@samfundet.no>
Date:	Wed, 13 Feb 2013 00:49:21 +0100
From:	Hans-Christian Egtvedt <egtvedt@...fundet.no>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Haavard Skinnemoen <hskinnemoen@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] avr32: atmel_default_console_device depends on
 CONFIG_SERIAL_ATMEL

Around Tue 12 Feb 2013 15:27:35 +0100 or thereabout, Geert Uytterhoeven wrote:
> allnoconfig:
> 
> arch/avr32/mach-at32ap/built-in.o: In function `at32_select_gpio':
> (.init.text+0x548): undefined reference to `atmel_default_console_device'

Indeed, I guess building without serial support has never been done.

> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>

Acked-by: Hans-Christian Egtvedt <egtvedt@...fundet.no>

> ---
>  arch/avr32/mach-at32ap/at32ap700x.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c
> index b323d8d..a2fe61b 100644
> --- a/arch/avr32/mach-at32ap/at32ap700x.c
> +++ b/arch/avr32/mach-at32ap/at32ap700x.c
> @@ -1060,7 +1060,9 @@ struct platform_device *__init at32_add_device_usart(unsigned int id)
>  
>  void __init at32_setup_serial_console(unsigned int usart_id)
>  {
> +#ifdef CONFIG_SERIAL_ATMEL
>  	atmel_default_console_device = at32_usarts[usart_id];
> +#endif
>  }
>  
>  /* --------------------------------------------------------------------
-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/