lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Feb 2013 17:13:44 +0100 From: Sebastian Andrzej Siewior <bigeasy@...utronix.de> To: Steven Rostedt <rostedt@...dmis.org> Cc: linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org, Carsten Emde <C.Emde@...dl.org>, Thomas Gleixner <tglx@...utronix.de>, Sebastian Andrzej Siewior <bigeasy@...utronix.de> Subject: [PATCH 05/12] softirq: Add more debugging From: Thomas Gleixner <tglx@...utronix.de> We really want to find code which calls __raise_softirq_irqsoff() and runs neither in hardirq context nor in a local_bh disabled region. This is even wrong on mainline as that code relies on random events to take care of it's newly raised softirq. Signed-off-by: Thomas Gleixner <tglx@...utronix.de> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> --- kernel/softirq.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 72abc38..499329d 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -605,7 +605,7 @@ void thread_do_softirq(void) } } -void __raise_softirq_irqoff(unsigned int nr) +static void do_raise_softirq_irqoff(unsigned int nr) { trace_softirq_raise(nr); or_softirq_pending(1UL << nr); @@ -622,12 +622,19 @@ void __raise_softirq_irqoff(unsigned int nr) __this_cpu_read(ksoftirqd)->softirqs_raised |= (1U << nr); } +void __raise_softirq_irqoff(unsigned int nr) +{ + do_raise_softirq_irqoff(nr); + if (!in_irq() && !current->softirq_nestcnt) + wakeup_softirqd(); +} + /* * This function must run with irqs disabled! */ void raise_softirq_irqoff(unsigned int nr) { - __raise_softirq_irqoff(nr); + do_raise_softirq_irqoff(nr); /* * If we're in an hard interrupt we let irq return code deal @@ -649,11 +656,6 @@ void raise_softirq_irqoff(unsigned int nr) wakeup_softirqd(); } -void do_raise_softirq_irqoff(unsigned int nr) -{ - raise_softirq_irqoff(nr); -} - static inline int ksoftirqd_softirq_pending(void) { return current->softirqs_raised; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists