linux-kernel - Re: [PATCH v2 0/9] 3.8-rc regression with pps-ldisc due to 70ece7a731

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130213164547.GA8520@kroah.com>
Date:	Wed, 13 Feb 2013 08:45:47 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	George Spelvin <linux@...izon.com>,
	Rodolfo Giometti <giometti@...eenne.com>
Cc:	linux-serial@...r.kernel.org, peter@...leysoftware.com,
	linux-kernel@...r.kernel.org, giometti@...ux.it
Subject: Re: [PATCH v2 0/9] 3.8-rc regression with pps-ldisc due to 70ece7a731

On Tue, Feb 12, 2013 at 08:56:07AM -0500, George Spelvin wrote:
> The standard N_TTY line discipline used to not use the tty->disc_data
> field, so N_PPS felt free to use it.  That has now changed, requiring
> that N_PPS use a different method to find its private data.
> 
> (In the current, buggy, state, N_PPS follows a wild pointer and explodes
> in an interrupt hander as soon as a pulse actually arrives.)
> 
> Compared to v1, this has been rearranges to the first three patches are
> the minimial bugfixes:
> 
> * 1/9 "Add pps_lookup_dev() function"
>   This adds the infrastructure necessary to bypass disc_data use.
> 
> * 2/9 "Use pps_lookup_dev to reduce ldisc coupling"
>   This actually fixes the bug.
> 
> * 3/9 "Fix a use-after free bug when unregistering a source."
>   This is actually an old bug, present before 3.7.  I'd like to solicit
>   feedback from folks who know device drivers better to ask if I did
>   things right.  I'd also appreciate a look at patch 8/9 which is a more
>   aggressive cleanup of the same bug.

I can take these through my tty tree, but it would be very good if I
actually had the ack from the PPS maintainer...

Rodolfo, any objection for me taking these?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/