linux-kernel - Re: [PATCH -next 1/1] net: skbuff: fix compile error in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130213194307.GE13159@mail.gmail.com>
Date:	Wed, 13 Feb 2013 12:43:07 -0700
From:	Jean Sacren <sakiwit@...il.com>
To:	James Hogan <james.hogan@...tec.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH -next 1/1] net: skbuff: fix compile error in skb_panic()

From: James Hogan <james.hogan@...tec.com>
Date: Wed, 13 Feb 2013 11:20:27 +0000
>
> I get the following build error on next-20130213 due to the following
> commit:
> 
> commit f05de73bf82fbbc00265c06d12efb7273f7dc54a ("skbuff: create
> skb_panic() function and its wrappers").
> 
> It adds an argument called panic to a function that uses the BUG() macro
> which tries to call panic, but the argument masks the panic() function
> declaration, resulting in the following error (gcc 4.2.4):
> 
> net/core/skbuff.c In function 'skb_panic':
> net/core/skbuff.c +126 : error: called object 'panic' is not a function
> 
> This is fixed by renaming the argument to msg.
> 
> Signed-off-by: James Hogan <james.hogan@...tec.com>

Thanks, James.

I'm sorry I introduced this bug. Shame on me.

-- 
Jean Sacren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/