linux-kernel - Re: [PATCH 02/10] Input: atmel_mxt_ts - register input device before request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130213214214.GB23390@core.coreip.homeip.net>
Date:	Wed, 13 Feb 2013 13:42:15 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Daniel Kurtz <djkurtz@...omium.org>
Cc:	Henrik Rydberg <rydberg@...omail.se>,
	Benson Leung <bleung@...omium.org>,
	Yufeng Shen <miletus@...omium.org>,
	Nick Dyer <nick.dyer@...ev.co.uk>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	olofj@...omium.org
Subject: Re: [PATCH 02/10] Input: atmel_mxt_ts - register input device before
 request_irq

Hi Daniel,

On Fri, Feb 01, 2013 at 04:11:44PM +0800, Daniel Kurtz wrote:
> As soon as the irq is request, input event interrupts could occur that
> the isr should handle.  Similarly, if there are input events queued up
> in the device output buffer, it will send them immediately when we
> drain the message buffer with mxt_handle_messages.
> 
> Therefore, register the input device before enabling the irq (or handling
> messages).

I do not see the point. The allocated device can withstand
input_events() calls even without being registered and I am not sure why
anyone would be particularly interested in events that happened before
or during device registration, espceially for a touchscreen device.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/