lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Feb 2013 23:46:47 +0100 From: Wim Van Sebroeck <wim@...ana.be> To: Wenyou Yang <wenyou.yang@...el.com> Cc: linux-arm-kernel@...ts.infradead.org, nicolas.ferre@...el.com, plagnioj@...osoft.com, fabio.porcedda@...il.com, JM.Lin@...el.com, linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 1/8] watchdog: add the function watchdog_is_open Hi Wenyou, > Add the function watchdog_is_open to check whether or not > the /dev/watchdog? is opened > > Signed-off-by: Wenyou Yang <wenyou.yang@...el.com> > Cc: wim@...ana.be > Cc: linux-watchdog@...r.kernel.org > Cc: linux-kernel@...r.kernel.org > --- > include/linux/watchdog.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h > index e40cc2b..7ea4465 100644 > --- a/include/linux/watchdog.h > +++ b/include/linux/watchdog.h > @@ -111,6 +111,14 @@ static inline bool watchdog_active(struct watchdog_device *wdd) > return test_bit(WDOG_ACTIVE, &wdd->status); > } > > +/* Use the following function to check whether or not > + * the /dev/watchdog? is opened > + */ > +static inline bool watchdog_is_open(struct watchdog_device *wddev) > +{ > + return test_bit(WDOG_DEV_OPEN, &wddev->status); > +} > + > /* Use the following function to set the nowayout feature */ > static inline void watchdog_set_nowayout(struct watchdog_device *wdd, bool nowayout) > { NAK, this is not good. You should use watchdog_active instead. Reason: your device could have been opened as for instance /dev/watchdog0. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists