linux-kernel - Re: linux-next: Tree for Feb 13 (virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130214180651.900763c3986c94531bb01ecf@canb.auug.org.au>
Date:	Thu, 14 Feb 2013 18:06:51 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Randy Dunlap <rdunlap@...radead.org>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, Amit Shah <amit.shah@...hat.com>,
	virtualization@...ts.linux-foundation.org,
	Michal Marek <mmarek@...e.cz>, linux-kbuild@...r.kernel.org,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: linux-next: Tree for Feb 13 (virtio_console)

Hi Rusty,

On Thu, 14 Feb 2013 13:30:37 +1030 Rusty Russell <rusty@...tcorp.com.au> wrote:
>
> This looks like an impossible config.  CONFIG_VIRTIO_CONSOLE=y, but
> CONFIG_HVC_DRIVER isn't set.
> 
> From drivers/char/Kconfig:
> 
>         config VIRTIO_CONSOLE
>         	tristate "Virtio console"
>         	depends on VIRTIO

This also has "&& TTY" in -next (not actually relevant)

>         	select HVC_DRIVER

Its weird, but since CONFIG_TTY is not set (see the config), the
HVC_DRIVER symbol is not even visible, so I suspect that the above select
does nothing :-(  But also, I can't see how VIRTIO_CONSOLE could be set
in the first place since TTY is not set.

(cc'ing some more people) (this is a randconfig that has TTY=n,
HVC_DRIVER=n, but VIRTIO_CONSOLE=y)
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped