linux-kernel - Re: [PATCH v4 4/8] watchdog/at91sam9_wdt: Adjust the options of watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1459249.A0040oxoB3@ws-stein>
Date:	Thu, 14 Feb 2013 09:12:10 +0100
From:	Alexander Stein <alexander.stein@...tec-electronic.com>
To:	Wim Van Sebroeck <wim@...ana.be>,
	Wenyou Yang <wenyou.yang@...el.com>
Cc:	linux-arm-kernel@...ts.infradead.org, nicolas.ferre@...el.com,
	plagnioj@...osoft.com, fabio.porcedda@...il.com, JM.Lin@...el.com,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/8] watchdog/at91sam9_wdt: Adjust the options of watchdog_info

Hello,

On Thursday 14 February 2013 00:15:22, Wim Van Sebroeck wrote:
> Hi Wenyou,
> 
> > Since the Watchdog Timer Mode Register can be only written only once,
> > so the watchdog_info shall not support WDIOF_SETTIMEOUT
> > and WDIOF_MAGICCLOSE options, remove them.
> 
> Ik you keep using the timer, then you don't have to remove this.

Why removing especially WDIOF_MAGICCLOSE (and the timer needed for that)? This is a feature removal. Without there isn't even a need for nowayout option as it is implicitly set anyway.
Nevertheless I would prefere keeping the timer to allow a user to let the kernel triggering the timer upon MAGICCLOSE.

Alexander

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/