linux-kernel - Re: [RFC PATCH] regmap: mmio: add register clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130214115621.GE13249@opensource.wolfsonmicro.com>
Date:	Thu, 14 Feb 2013 11:56:22 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] regmap: mmio: add register clock support

On Thu, Feb 14, 2013 at 10:49:14AM +0100, Philipp Zabel wrote:

> Some mmio devices have a dedicated interface clock that needs
> to be enabled to access their registers. This patch optionally
> enables a clock before accessing registers in the regmap_bus
> callbacks.

This is a good feature but a couple of concerns here.

> +	if (ctx->clk)
> +		clk_prepare_enable(ctx->clk);
> +

This is only going to work if prepare doesn't sleep.  That's probably
fine for the use cases we're interested in but doesn't fill me with joy.
The other thing is that we ought to check the return value.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)