linux-kernel - Re: [PATCH 1/2] regmap: debugfs: Add a registers `range' file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130214144305.GP13249@opensource.wolfsonmicro.com>
Date:	Thu, 14 Feb 2013 14:43:06 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] regmap: debugfs: Add a registers `range' file

On Thu, Feb 14, 2013 at 12:31:44PM +0000, Dimitris Papastamos wrote:

> @@ -96,6 +116,7 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
>  				if (c) {
>  					c->max = p - 1;
>  					c->max_reg = i - 1;
> +					c->reg_attr = regmap_attr_bitmap(map, c->max_reg);
>  					list_add_tail(&c->list,
>  						      &map->debugfs_off_cache);
>  					c = NULL;

What happens if we have three registers like below?

   X:   read, write
   X+1: read, write, volatile
   X+2: read, write

It looks like we'll not flag X+1 as volatile, we'll just take the last
value we saw.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)